From: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
Date: Fri, 04 Sep 2026 04:20:11 GMT
Subject: Re: [PATCH] branch: avoid slow strvec Coccinelle matching
Message-ID: <CALk1092+d4kazT-cQuN3Xih2cJNBC8mBAbyR0YPELWT37K9KDg@mail.gmail.com>
In-Reply-To: <20260726074122.GB2366012@coredump.intra.peff.net>

Hi Junio, Jeff,

I'm Emmanuel Ugwu, new to the project and looking to get involved.
I noticed this #leftoverbits from
<https://github.com/pabloosabaterr/WhatToGit/blob/main/leftoverbits.md>.
I have gone through the thread, the desired fix is to fix the inconsistencies
in type by choosing/using a wide-enough type to avoid overflow (size_t) right?

Is now a reasonable time to start looking into this, or would you
rather it wait until 'hn/branch-delete-merged' has settled?

Thanks,
Emmanuel Ugwu

On Sun, Jul 26, 2026 at 8:41 AM Jeff King <peff@peff.net> wrote:
>
> On Fri, Jul 24, 2026 at 10:33:05AM -0700, Junio C Hamano wrote:
>
> > Here is what I recommend that we do.  In the short term, i.e.,
> > within the context of the topic in question, let's use 'int' to
> > match the type used to count the members of an array embedded in
> > 'struct ref_array'.
> >
> > But let's leave a '#leftoverbits' note here in the mailing list
> > archive to remind us to revisit the idea of consistently using
> > 'size_t' to count things when things are quiet.  This is not the
> > time to needlessly disrupt the 'hn/branch-delete-merged' topic, I
> > think.
>
> Yep, agreed on all points.
>
> -Peff
>