From: Antoine Pelisse <apelisse@gmail.com>
Date: Tue, 28 Apr 2020 04:18:36 GMT
Subject: Re: all memory consuming `git diff-tree` bug
Message-ID: <CALWbr2zjL5pKrvk1pRXUKgOLE+kVKzLjR3ofUOhRruAbiVVovg@mail.gmail.com>
In-Reply-To: <20200428041010.GA2371637@coredump.intra.peff.net>

On Mon, Apr 27, 2020 at 9:10 PM Jeff King <peff@peff.net> wrote:
> Without engaging my brain to think about what this code is doing or
> whether there might be clever solutions, it really sounds like we might
> consider using this quadratic code for small cases if it produces better
> results, and then switching to the less-accurate greedy implementation
> when we need to.

I remember having the exact same thought at the time I wrote this, but
my limited tests with 10k lines files were fine so I discarded it.

Falling-back on the greedy algorithm seems reasonable in that case.

Antoine