From: Antoine Pelisse <apelisse@gmail.com>
Date: Sat, 30 Nov 2013 12:19:37 GMT
Subject: Re: [PATCH v4 12/24] read-cache: read index-v5
Message-ID: <CALWbr2ybgpdDJLRKA4zwPmRE4LQv4VWLJM6Jv0dO-GyHREGW7g@mail.gmail.com>
In-Reply-To: <1385553659-9928-13-git-send-email-t.gummerer@gmail.com>

On Wed, Nov 27, 2013 at 1:00 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
> Make git read the index file version 5 without complaining.
>
> This version of the reader reads neither the cache-tree
> nor the resolve undo data, however, it won't choke on an
> index that includes such data.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
> Helped-by: Thomas Rast <trast@student.ethz.ch>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---
> [...]
> +static struct directory_entry *read_directories(unsigned int *dir_offset,
> +                                               unsigned int *dir_table_offset,
> +                                               void *mmap, int mmap_size)

Minor nit: why is this mmap_size "int" while all others are "unsigned long" ?

> [...]
> +static int read_entry(struct cache_entry **ce, char *pathname, size_t pathlen,
> +                     void *mmap, unsigned long mmap_size,
> +                     unsigned int first_entry_offset,
> +                     unsigned int foffsetblock)
> [...]
> +static int read_entries(struct index_state *istate, struct directory_entry *de,
> +                       unsigned int first_entry_offset, void *mmap,
> +                       unsigned long mmap_size, unsigned int *nr,
> +                       unsigned int foffsetblock)
> [...]
> +static int read_index_v5(struct index_state *istate, void *mmap,
> +                        unsigned long mmap_size, struct filter_opts *opts)