From: Tay Ray Chuan <rctay89@gmail.com>
Date: Thu, 13 Oct 2011 02:06:40 GMT
Subject: Re: [PATCH] http_init: accept separate URL parameter
Message-ID: <CALUzUxp-Qe05+VF_EDg3+iHBeqWcEfcSVp3fyV_fQjAUaCVjOA@mail.gmail.com>
In-Reply-To: <20111012214316.GA4393@sigill.intra.peff.net>

On Thu, Oct 13, 2011 at 5:43 AM, Jeff King <peff@peff.net> wrote:
> The http_init function takes a "struct remote". Part of its
> initialization procedure is to look at the remote's url and
> grab some auth-related parameters. However, using the url
> included in the remote is:
>
>  - wrong; the remote-curl helper may have a separate,
>    unrelated URL (e.g., from remote.*.pushurl). Looking at
>    the remote's configured url is incorrect.
>
>  - incomplete; http-fetch doesn't have a remote, so passes
>    NULL. So http_init never gets to see the URL we are
>    actually going to use.
>
>  - cumbersome; http-push has a similar problem to
>    http-fetch, but actually builds a fake remote just to
>    pass in the URL.
>
> Instead, let's just add a separate URL parameter to
> http_init, and all three callsites can pass in the
> appropriate information.
>
> Signed-off-by: Jeff King <peff@peff.net>

This is excellent.

  Acked-by: Tay Ray Chuan <rctay89@gmail.com>

-- 
Cheers,
Ray Chuan