From: Tay Ray Chuan <rctay89@gmail.com>
Date: Wed, 09 Oct 2013 10:20:40 GMT
Subject: Re: [PATCH] git-subtree: Avoid using echo -n even indirectly
Message-ID: <CALUzUxovH5MTP1_DMigRx1Hp+X6v3_YdLK2vSG4KwRLNSDHN-w@mail.gmail.com>
In-Reply-To: <1381291045-98372-1-git-send-email-p.giarrusso@gmail.com>

On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso
<p.giarrusso@gmail.com> wrote:
> diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
> index 7d7af03..ebfb78f 100755
> --- a/contrib/subtree/git-subtree.sh
> +++ b/contrib/subtree/git-subtree.sh
> @@ -592,7 +592,9 @@ cmd_split()
>         eval "$grl" |
>         while read rev parents; do
>                 revcount=$(($revcount + 1))
> -               say -n "$revcount/$revmax ($createcount)
> "
> +               if [ -z "$quiet" ]; then
> +                       printf "%s" "$revcount/$revmax ($createcount)
> " >&2
> +               fi

Reviewers might wish to know that "say" in git-subtree is defined as

        say()
        {
                if [ -z "$quiet" ]; then
                        echo "$@" >&2
               fi
        }

Hence the "if" and the redirect.

-- 
Cheers,
Ray Chuan