From: Armin Kunaschik Date: Tue, 24 May 2016 17:20:21 GMT Subject: Re: t7800 test failure Message-ID: In-Reply-To: On Tue, May 24, 2016 at 6:57 PM, Junio C Hamano wrote: > Matthieu Moy writes: > >> Armin Kunaschik writes: >> >>> t7800 fails on systems where readlink (GNUism?) is not available. >> >> I don't think it's POSIX, but it is present on all POSIX-like systems I >> know. On which system did you get the issue? It's not available in AIX or HP-UX. >>> +readlink() { ls -ld "$1" | sed 's/.* -> //'; } >> >> This is much less robust than the actual readlink. For example, if -> >> appears in the link name, it breaks. > > I wouldn't allow it in our scripted Porcelain, but the environment > of our test scripts are under our control, so I do not think it is a > problem ("ls piped to sed" has been an established idiom before > readlink(1) was widely accepted, by the way). I think so too. Maybe I can improve the sed expression a bit, but it will never be a universal readlink replacement. But it doesn't have to. It's defined locally for this one test only and it does the specific job. >> It would be acceptable as a fall-back if readlink is not present, but >> shouldn't activate the "ls" hack by default. > > Yup. Ok, how can this be implemented within the test environment?