From: Johan Herland Date: Mon, 08 Sep 2014 15:13:45 GMT Subject: Re: [RFC/PATCH 0/3] Teach revert/cherry-pick the --no-verify option Message-ID: In-Reply-To: <540A2598.8000101@gmail.com> On Fri, Sep 5, 2014 at 11:05 PM, Fabian Ruch wrote: > neither git-cherry-pick nor git-revert execute the pre-commit or > commit-msg hooks at the moment. The underlying rationale can be found in > the log message of commit 9fa4db5 ("Do not verify > reverted/cherry-picked/rebased patches."). Indeed, the sequencer uses > git-commit internally which executes the two verify hooks by default. > However, the particular command line being used implicitly specifies the > --no-verify option. This behaviour is implemented in > sequencer.c#run_git_commit as well, right before the configurable > git-commit options are handled. I guess that's easily overlooked since > the documentation doesn't mention it and the implementation uses the > short version -n of --no-verify. Damn. You're obviously correct, and my patch series is seriously misguided. Please drop it, Junio, and I'm very sorry for the noise. Hopefully, I will learn not to blindly follow my assumptions. ...Johan -- Johan Herland, www.herland.net