From: Johan Herland <johan@herland.net>
Date: Tue, 11 Nov 2014 01:04:46 GMT
Subject: Re: [PATCHv4 9/9] t3301: Modernize
Message-ID: <CALKQrgec-_9kbqba7PBFvNpCpeRAb=Pq6-OMnrJ2nw0fh_5LjQ@mail.gmail.com>
In-Reply-To: <xmqqioim9498.fsf@gitster.dls.corp.google.com>

On Mon, Nov 10, 2014 at 9:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Johan Herland <johan@herland.net> writes:
>
>> Make this test script appear somewhat less old-fashioned:
>>  - Use test helper functions:
>>     - write_script
>>     - test_commit
>>     - test_write_lines
>>     - test_config
>>     - test_unconfig
>>     - test_path_is_missing
>>  - Remove whitespace between redirection operators and their targets.
>>  - Move preparation of "except" files into tests.
>
> expect, I think (no need to resend; I've fixed it up locally).

Thanks.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net