From: Johan Herland <johan@herland.net>
Date: Wed, 25 Mar 2015 08:40:47 GMT
Subject: Re: [PATCH 3/8] t3305: fix ignored exit code inside loop
Message-ID: <CALKQrge+KKHg3GtGz=rg3YQEnzN_tthqW4hrTDjFt96vnuGk9Q@mail.gmail.com>
In-Reply-To: <20150325052856.GC31924@peff.net>

On Wed, Mar 25, 2015 at 6:28 AM, Jeff King <peff@peff.net> wrote:
> When we test deleting notes, we run "git notes remove" in a
> loop. However, the exit value of the loop will only reflect
> the final note we process. We should break out of the loop
> with a failing exit code as soon as we see a problem.
>
> Note that we can call "exit 1" here without explicitly
> creating a subshell, because the while loop on the
> right-hand side of a pipe executes in its own implicit
> subshell.
>
> Note also that the "break" above does not suffer the same
> problem; it is meant to exit the loop early at a certain
> number of iterations. We can bump it into the conditional of
> the loop to make this more obvious.
>
> Signed-off-by: Jeff King <peff@peff.net>

Acked-by: Johan Herland <johan@herland.net>

-- 
Johan Herland, <johan@herland.net>
www.herland.net