From: Johan Herland <johan@herland.net>
Date: Sat, 26 Aug 2017 23:36:32 GMT
Subject: Re: [PATCH 00/12] Clean up notes-related code around `load_subtree()`
Message-ID: <CALKQrgdRwch4d837OwOJUxPPmUc43janx1VROvAoEJG2ef3SJA@mail.gmail.com>
In-Reply-To: <cover.1503734566.git.mhagger@alum.mit.edu>

On Sat, Aug 26, 2017 at 10:28 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
[...]
> plenty that could be cleaned up in the area:
>
> * Make macro `GIT_NIBBLE` safer by adding some parentheses
> * Remove some dead code
> * Fix some memory leaks
> * Fix some obsolete and incorrect comments
> * Reject "notes" that are not blobs
>
> I hope the result is also easier to understand.

I looked through the series, and the patches look good to me, although
I do agree with Junio's comments on #2.

Thanks for a long-overdue cleanup in one of the hairier parts of
the notes code. The end result reads a lot better IMHO.

...Johan