From: Johan Herland Date: Fri, 10 Jul 2015 07:16:16 GMT Subject: Re: [PATCH v4] notes: Allow treeish expressions as notes ref Message-ID: In-Reply-To: <1436491711-19056-1-git-send-email-mh@glandium.org> On Fri, Jul 10, 2015 at 3:28 AM, Mike Hommey wrote: > init_notes() is the main point of entry to the notes API. It is an arbitrary > restriction that all it allows as input is a strict ref name, when callers > may want to give an arbitrary treeish. > > However, some operations that require updating the notes tree require a > strict ref name, because they wouldn't be able to update e.g. foo@{1}. > > So we allow treeish expressions to be used in the case the notes tree is > going to be used without write "permissions", and to distinguish whether > the notes tree is intended to be used for reads only, or will be updated, > a flag is added. > > This has the side effect of enabling the use of treeish as notes refs in > commands allowing them, e.g. git log --notes=foo@{1}. Looks good. However, on a second pass I noticed that the patch comes with no tests. I'd like at least a couple of tests thrown in there to verify correctness; e.g. reading notes from refs/notes/commits^{tree} shall succeed, and trying to write notes to refs/notes/commits^{tree} shall fail. ...Johan -- Johan Herland, www.herland.net