From: Johan Herland <johan@herland.net>
Date: Wed, 09 Oct 2013 12:18:11 GMT
Subject: Re: [RFC/PATCHv2 2/3] git-svn: Warn about changing default for --prefix in Git v2.0
Message-ID: <CALKQrgd3wPEwK2vHkFPgt2hXASwB0ypAjzvnR8fV-WAgjggdqg@mail.gmail.com>
In-Reply-To: <CAPig+cRAg4NpAsUWGQPsLcaFmDn61POv1pdHKCrSyQbM0KgM4A@mail.gmail.com>

On Wed, Oct 9, 2013 at 3:34 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Oct 5, 2013 at 7:30 PM, Johan Herland <johan@herland.net> wrote:
>> diff --git a/t/t9117-git-svn-init-clone.sh b/t/t9117-git-svn-init-clone.sh
>> index b7ef9e2..1c8d049 100755
>> --- a/t/t9117-git-svn-init-clone.sh
>> +++ b/t/t9117-git-svn-init-clone.sh
>> @@ -52,4 +52,71 @@ test_expect_success 'clone to target directory with --stdlayout' '
>>         rm -rf target
>>         '
>>
>> +test_expect_success 'clone without -s/-T/-b/-t does not warn' '
>> +       test ! -d trunk &&
>> +       git svn clone "$svnrepo"/project/trunk 2>warning &&
>> +       test_must_fail grep -q prefix warning &&
>> +       rm -rf trunk &&
>> +       rm -f warning
>> +       '
>> +
>> +test_svn_configured_prefix () {
>> +       prefix=$1
>
> Did you want to maintain the &&-chain here?
>
>> +       cat >expect <<EOF
>
> And here?

Yes, will add && in both places. Thanks.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net