From: Johan Herland <johan@herland.net>
Date: Thu, 04 Sep 2014 08:34:20 GMT
Subject: Re: [RFC/PATCH 2/3] revert/cherry-pick: Add --no-verify option, and pass it on to commit
Message-ID: <CALKQrgcdEMcFWhT7ZSKYR23QL7=_CKXRKxwZ_nOCSzRzPk0TGg@mail.gmail.com>
In-Reply-To: <xmqq7g1kxzxi.fsf@gitster.dls.corp.google.com>

On Wed, Sep 3, 2014 at 9:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Johan Herland <johan@herland.net> writes:
>> diff --git a/builtin/revert.c b/builtin/revert.c
>> index f9ed5bd..831c2cd 100644
>> --- a/builtin/revert.c
>> +++ b/builtin/revert.c
>> @@ -91,6 +91,7 @@ static void parse_args(int argc, const char **argv, struct replay_opts *opts)
>>                       N_("option for merge strategy"), option_parse_x),
>>               { OPTION_STRING, 'S', "gpg-sign", &opts->gpg_sign, N_("key-id"),
>>                 N_("GPG sign commit"), PARSE_OPT_OPTARG, NULL, (intptr_t) "" },
>> +             OPT_BOOL('n', "no-verify", &opts->no_verify, N_("bypass pre-commit hook")),
>
> I doubt we want this option to squat on '-n'; besides, it is already
> taken by a more often used "--no-commit".

Oops. I never meant to squat on '-n'. Will fix in re-roll.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net