From: Johan Herland <johan@herland.net>
Date: Wed, 25 Sep 2013 10:10:58 GMT
Subject: Re: [PATCH] sample pre-commit hook: Use --bool when retrieving config var
Message-ID: <CALKQrgc_5PhN-PsnCPnxcoN+zNKGo1CEJZw0CZzPXvu6aG23uA@mail.gmail.com>
In-Reply-To: <20130924192259.GN9464@google.com>

On Tue, Sep 24, 2013 at 9:22 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Johan Herland wrote:
>> Signed-off-by: Johan Herland <johan@herland.net>
>
> Thanks.
>
> What symptoms does this alleviate?  Is this to allow configurations like
>
>         [hooks]
>                 allowNonAscii = 1
>
> and
>
>         [hooks]
>                 allowNonAscii
>
> to do the expected thing, or is it something more subtle than that?

Nothing subtle. Just what you list. And for consistency with the other
sample hooks' use of "git config".

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net