From: Matthieu Beauchamp Date: Tue, 06 Jan 2026 19:52:36 GMT Subject: Re: [PATCH] ignores: handle non UTF-8 exclude files Message-ID: In-Reply-To: On Sat, Jan 3, 2026 at 9:54 PM Junio C Hamano wrote: > > "Matthieu Beauchamp-Boulay via GitGitGadget" > writes: > > > From: Matthieu Beauchamp-Boulay > > > > When reading exclude files, git assumes it is encoded in UTF-8 and will > > fail to apply patterns if it isn't. > > Is it true? I thought we assume that the exclude patters are > written in such a way to match the encoding of the pathnames, > whatever used on the platform that our calls to readdir(3) returns. > Some platforms may have compat/ code to convert these paths and > force use of UTF-8, but please do not write such platform local > conventions as if it were universal characteristics of our system. I believe you are correct, I wrongly assumed git would always manipulate UTF-8 paths. The revision will need to take the platform into consideration. > "ignores" -> "exclude" on the title, as that is the canonical word > we use in the codebase to refer to the ignore mechanism. Thank you, I will update in the revision.