From: Pushkar Singh Date: Thu, 08 Jan 2026 18:15:59 GMT Subject: Re: [PATCH 6/6] doc: patch-id: --verbatim locks in --stable Message-ID: In-Reply-To: <--verbatim_and_--stable.1b1@msgid.xyz> Hi Kristoffer, I read through the entire series and all six changes look correct to me. Each patch is small and focused, and together they improve the clarity, consistency, and accuracy of the git-patch-id documentation without changing meaning. In particular, spelling out the `git diff-tree --patch` form and documenting the `--verbatim` / `--stable` relationship help align the docs more closely with the actual behavior and existing code. I didn’t notice any issues with the changes. Thanks for working on this, Pushkar On Thu, Jan 8, 2026 at 12:02 PM wrote: > > From: Kristoffer Haugsbakk > > The default `--unstable` is a legacy format that predates `--stable`. > That’s why 2871f4d4 (builtin: patch-id: add --verbatim as a command mode, > 2022-10-24) made `--verbatim` lock in[1] `--stable`: > > Users of --unstable mainly care about compatibility with old git > versions, which unstripping the whitespace would break. Thus there > isn't a usecase for the combination of --verbatim and --unstable, > and we don't expose this so as to not add maintainence burden. > > † 1: imply `--stable`, disallow `--unstable > > Signed-off-by: Kristoffer Haugsbakk > --- > Documentation/git-patch-id.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/git-patch-id.adoc b/Documentation/git-patch-id.adoc > index 61498def317..013e1a61906 100644 > --- a/Documentation/git-patch-id.adoc > +++ b/Documentation/git-patch-id.adoc > @@ -32,7 +32,7 @@ OPTIONS > > `--verbatim`:: > Calculate the patch ID of the input as it is given, do not strip > - any whitespace. > + any whitespace. Implies `--stable` and forbids `--unstable`. > + > This is the default if `patchid.verbatim` is `true`. > > -- > 2.52.0.421.gc32ead4fc78 > >