From: Pushkar Singh Date: Tue, 17 Mar 2026 17:20:00 GMT Subject: Re: [GSoC][RFC v2] Proposal: Improve the new git repo command Message-ID: In-Reply-To: Hi Karthik, Thanks for your review, this was very helpful. > Which existing helpers? I was referring to helpers used by git rev-parse and related path resolution logic, such as repo_git_pathv() and repo_common_path(). I’ll make sure to explicitly clarify this and ensure reuse of existing helpers instead of introducing new path handling logic. > It would be nice if you explained a bit about this, what is the current > condition what are your thoughts and what do you plan to implement. Makes sense. I’ll expand this section to describe the current ambiguity around absolute vs relative paths, and outline the approaches being discussed along with what I plan to follow. > I'd be very interested in what the current test scenario looks like > and how we'll improve on top of that. Got it. I’ll include the current coverage in t1900-repo-info.sh and describe how I plan to extend it across different repository setups. > I'm not sure what the last sentence here means. Understood. I’ll rephrase this to make it more concrete. > In this cycle? IF we do go with category-based queries, isn't that a > design choice which affects all git repo info keys? Would we need to > specifically solve for path keys? That’s a good point. I’ll clarify this and describe category-based queries as a general design choice rather than something tied only to path keys. > What do you mean by this? I meant identifying areas in builtin/repo.c where structural changes may be required while adding new fields. I’ll make this more precise. I’ll incorporate these changes and send a revised version (v3) shortly. Regards, Pushkar