From: Kristofer Karlsson Date: Fri, 10 Jul 2026 17:40:57 GMT Subject: Re: [PATCH v3 0/2] prio-queue: use bottom-up sift for extract-min Message-ID: In-Reply-To: On Fri, 10 Jul 2026 at 18:37, René Scharfe wrote: > > On 7/8/26 7:49 PM, Kristofer Karlsson via GitGitGadget wrote: > > Note: sift_up() currently uses swap, matching the existing code style. It > > could be further optimized to use copy (hold the element in a temp, shift > > parents down, write once), but that would require changing compare() to > > accept element values instead of array indices. Left for a potential > > follow-up. > > Same for sift_down_root(), I guess? It could almost halve the number of > writes, right? I wonder how much of that benefit will be eaten by > caching. Hm yes indeed, I stopped looking past sift_up() when I realized I should not expand the scope of the change. But I think the CPU cache effectively makes the swap almost as cheap in practice. - Kristofer