From: Kristofer Karlsson Date: Mon, 09 Nov 2026 13:05:25 GMT Subject: Re: [PATCH 2/3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS Message-ID: In-Reply-To: On Mon, 9 Nov 2026 at 10:33, Johannes Sixt wrote: > > Am 08.11.26 um 17:34 schrieb Johannes Sixt: > > Am 08.11.26 um 13:24 schrieb Kristofer Karlsson: > >> - test-tool genzeros 2147483649 | tr "\000" "1" >expect && > >> + printf 000000000%02147483640d 0 >expect && > >> > >> I tried this out and it works on Linux but fails on macOS[1]. What > >> happens is that printf only outputs the nine literal zeros > >> ("000000000") there, and silently ignores the very large padding. > > > > Fair enough. > > > >> [1] https://github.com/gitgitgadget/git/actions/runs/42475956442/job/128717309586 > > Well, this patch passed for me[2], but I have no idea whether the > particular tests were skipped due to the EXPENSIVE prerequisite or not. > > [2] https://github.com/j6t/git/actions/runs/42583623620/job/129048078411 > > > > diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh > index 01b97c8888..5dedb9054e 100755 > --- a/t/t4205-log-pretty-formats.sh > +++ b/t/t4205-log-pretty-formats.sh > @@ -1182,7 +1182,8 @@ unfold () { > ' > > test_expect_success EXPENSIVE,SIZE_T_IS_64BIT 'set up huge commit' ' > - test-tool genzeros 2147483649 | tr "\000" "1" >expect && > + # 3 * 715827883 == 2147483649 > + printf %0715827883d 0 0 0 >expect && > huge_commit=$(git commit-tree -F expect HEAD^{tree}) I tested this and it passes on all the macOS jobs. t4205 goes from 800-900s to 170-280s there, so your idea works well. Two caveats: the printf builtin in bash 3.2 (/bin/sh on macOS) silently prints nothing for a field wider than INT_MAX - 15, and it builds each field in memory, so this peaks at about 2.1GB RSS. Both go away by writing in 1MiB chunks, at the same speed: gen_ascii_zeros () { _n=$1 while test "$_n" -gt 0 do _chunk=$(( _n > 1048576 ? 1048576 : _n )) printf "%0${_chunk}d" 0 || return 1 _n=$(( _n - _chunk )) done } as a local helper in t4205. That fixes the slow test without a new test-tool, at the cost of yet another way of generating test data alongside genzeros and "genzeros | tr". I have it ready locally as a single patch, as an alternative to this series, but perhaps it's best to wait for more people to chime in first. Thanks, Kristofer