From: Kristofer Karlsson Date: Wed, 08 Jul 2026 07:28:16 GMT Subject: Re: [PATCH 1/2] t: add tests for ref tombstone scenarios Message-ID: In-Reply-To: On Wed, 8 Jul 2026 at 08:00, Patrick Steinhardt wrote: > > > > > I could not find an existing test that covers the delete-then-recreate > > flow (where tombstones are present when the new refs are created). > > The existing tests cover creation and deletion separately but not the > > interaction with tombstones. > > (But perhaps such a test exists and I just can't find it.) > > In t1400 we definitely have some tests where we exercise this > implicitly. In any case, if we want to retain this test I'd rather add > it to t1400 itself, as the functionality that we're testing is itself > not specific to the backend. Thanks, you are right about the placement -- the contract is valid regardless of backend. You are also right about it already being tested this is implicitly tested between multiple test runs since they have shared state (the repo). Multiple tests delete the ref as clean up and multiple tests also create a ref and verifies it. So it is technically covered but it depends on multiple tests being executed. I think this is simply exposing my personal preference to have more self-contained and explicit tests, but I am happy to drop the added tests -- it is perhaps more important to avoid bloating the test code. I will drop the added correctness test for the next iteration. Thanks, Kristofer