From: Kristofer Karlsson <krka@spotify.com>
Date: Mon, 29 Jun 2026 10:09:26 GMT
Subject: Re: [PATCH v4 6/8] commit-reach: remove unused nonstale_queue dedup wrappers
Message-ID: <CAL71e4N92t8170UBW3rMA6B-rEUeOm-R_HSioB957mUKOpwRyQ@mail.gmail.com>
In-Reply-To: <akIBvWT7nIWntCNT@szeder.dev>

On Mon, 29 Jun 2026 at 07:25, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> On Sun, Jun 28, 2026 at 12:25:44PM +0000, Kristofer Karlsson via GitGitGadget wrote:
> > From: Kristofer Karlsson <krka@spotify.com>
> >
> > nonstale_queue_put_dedup() and nonstale_queue_get_dedup() became
> > unused after the previous commit. The core nonstale_queue functions
> > remain in use by ahead_behind().
>
> Please squash this patch into the previous one.  Since the last
> callers of these static functions went away in that commit, it can't
> be built with DEVELOPER=1:
>
>   commit-reach.c:91:23: warning: ‘nonstale_queue_get_dedup’ defined but not used [-Wunused-function]
>      91 | static struct commit *nonstale_queue_get_dedup(struct nonstale_queue *queue)
>         |                       ^~~~~~~~~~~~~~~~~~~~~~~~
>   commit-reach.c:82:13: warning: ‘nonstale_queue_put_dedup’ defined but not used [-Wunused-function]
>      82 | static void nonstale_queue_put_dedup(struct nonstale_queue *queue,
>         |             ^~~~~~~~~~~~~~~~~~~~~~~~
>

Thanks, will squash for v5! It's unfortunate that this means the commit itself
becomes less clean, but I don't have any other good solution
-- and having each commit compile cleanly is more important.

- Kristofer