From: Kristofer Karlsson Date: Tue, 07 Jul 2026 17:39:37 GMT Subject: Re: [PATCH 1/2] commit-graph: add trace2 instrumentation for generation DFS Message-ID: In-Reply-To: On Tue, 7 Jul 2026 at 18:56, Junio C Hamano wrote: > > > > Add a step counter and trace2_data_intmax call to > > compute_reachable_generation_numbers() to make the cost of > > the generation number DFS observable. This exposes a > > regression introduced in 199d452758 (commit-graph: fix > > "filling in" topological levels, 2025-04-07) where > > Where did "fix filling in" came from? Are you blaming > > 199d452758 (commit-graph: return the prepared commit graph from > `prepare_commit_graph()`, 2025-09-04) > > or something else that happend in April that year? Hm, I actually don't remember that exact text, it must have been an oversight during editing back and forth and I missed it in my local review -- the commit oid is correct though, that is the one I was referring to. I will clean this up and shrink it down. I did not mean April though, but September 4th. I was using the ISO 8601 date format out of habit. > OK. I expect that [2/2] would update this exact test to demonstrate > that with code updated in [2/2] the extra walk will no longer happen. Yes, I first considered doing this as a single commit, but I figured it would be easier to reason about the fix if the problem was identified before-hand. Thanks, Kristofer