From: Kristofer Karlsson <krka@spotify.com>
Date: Wed, 24 Jun 2026 11:25:30 GMT
Subject: Re: [PATCH/RFC 2/6] commit-reach: introduce struct paint_queue with per-side counters
Message-ID: <CAL71e4Mx8=JFt+UcqiLN+Wb_UvGvF=SP81Nb3z_VZaEVahBfBg@mail.gmail.com>
In-Reply-To: <ec241a02-546c-4b5f-8ef7-06b4355d8fec@gmail.com>

On Tue, 23 Jun 2026 at 16:17, Derrick Stolee <stolee@gmail.com> wrote:
>
> I think this would be an appropriate way to handle this. If we
> pop and return NULL then it's ok that we removed data from the
> queue because it shouldn't be reused.

I have prepared v2 on GGG which I believe addresses all of the
feedback. The halt conditions now live inside paint_queue_get()
as you suggested.

I am not 100% happy with the halt-condition placement yet --
the existing loop in master already has several exit paths
(while condition, min_generation break, FIND_ALL break) and I
think there is an opportunity to consolidate them. But that is
a separate discussion and I do not want to derail this series.
I can propose some alternatives in a follow-up after this
lands.

Thanks,
Kristofer