From: Kristofer Karlsson Date: Mon, 13 Jul 2026 22:17:08 GMT Subject: Re: [PATCH 1/2] commit-graph: add trace2 instrumentation for generation DFS Message-ID: In-Reply-To: On Mon, 13 Jul 2026 at 22:42, Junio C Hamano wrote: > > I do not quite understand. Even if you fix the code and add a > passing test, the commit remains atomic. With an artificial > split, you only increase your commit count while making the changes > harder to review. When grouping a code fix with a newly passing > test: > > * "git show" displays both the implementation changes and the > test. You can review both, and if you agree with the behavior > expected by the test, the change is complete. > > * If the pre-fix behavior is unclear, it is easy to check by > running: > > $ git show ':!t/' | git apply -R && make test That's quite neat, and it matches the local development flow if you write the failing test first. I can see the advantages of grouping the test and bugfix in the same commit, and I'm happy to follow that convention going forward. > > Too late for this round, but I might give that a try in the future > > if I run into a similar scenario again. > > The existing tooling already supports this workflow (as demonstrated > by the command above). Please avoid artificially making the context > larger, as doing so increases the likelihood of merge conflicts with > other changes. Thanks, that makes sense. It was an interesting thought experiment, but I'll leave it there. - Kristofer