From: Kristofer Karlsson Date: Mon, 05 Oct 2026 14:47:34 GMT Subject: Re: [PATCH 2/2] fetch: write commit-graph using updated refs only Message-ID: In-Reply-To: On Mon, 5 Oct 2026 at 08:27, Patrick Steinhardt wrote: > > I will include these numbers in the cover letter of the reroll, > > or do you think it makes more sense to also have them in the commit > > message? > > I think it makes sense to have it as part of the commit message. Will do! > > However, I could change it to use status != REF_STATUS_NONE -- > > those are the only two statuses we can get so both would work, > > but I guess which one is best depends on what kind of new statuses > > could be added in the future. > > Okay, makes sense. I'd aim to be as defensive as possible, and defensive > here probably means that we should err on the side of covering too many > commits rather than covering not enough. And that's basically what > you're already doing anyway. > > I think having a short comment that explains this would help though. Agreed, will add a code comment + keep using REF_STATUS_REJECT_SHALLOW As you say, it makes sense to skip as few refs as possible here. I will also add a test case for shallow to prove that the check is important. Thanks, Kristofer