From: Оля Тележная Date: Thu, 18 Jan 2018 05:56:43 GMT Subject: Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter Message-ID: In-Reply-To: <20180117214515.GB13128@sigill.intra.peff.net> 2018-01-18 0:45 GMT+03:00 Jeff King : > On Tue, Jan 16, 2018 at 10:00:42AM +0300, Оля Тележная wrote: > >> > I think some of these will want to remain in cat-file.c. For instance, >> > split_on_whitespace is not something that ref-filter.c itself would care >> > about. I'd expect in the endgame for cat-file to keep its own >> > split_on_whitespace flag, and to set it based on the presence of the >> > %(rest) flag, which it can check by seeing if the "rest" atom is in the >> > "used_atom" list after parsing the format. >> >> Yes, maybe we will need to leave some part of expand_data variables. >> But, if it would be only "split_on_whitespace", it's better to make >> just one flag without any other stuff. Actually, I thought about >> moving related logic to ref-filter also. Anyway, it's hard to say >> exact things before we code everything. Do I need to fix commit >> message and make it more soft? > > Yeah, I think it might just be split_on_whitespace, and that could live > on as a single variable in cat-file.c. > > I don't think it makes sense to move that part to ref-filter, since it's > not about formatting at all. It's about how cat-file parses its input, > which is going to be unlike other ref-filter users (which don't > generally parse input at all). > > -Peff OK, I will leave split_on_whitespace in cat-file for now. :) There are so many places that are more important now, in my opinion, so I am planning just to leave this variable and do other stuff, and I will return to this question later.