From: Ronnie Sahlberg <sahlberg@google.com>
Date: Mon, 28 Apr 2014 18:27:15 GMT
Subject: Re: [PATCH v3 07/19] refs.c: remove the onerr argument to ref_transaction_commit
Message-ID: <CAL=YDWkEWjeTZi6QOzosiaJ1ZA5p6zcD2asbJ4o8NW=4EHxhVQ@mail.gmail.com>
In-Reply-To: <20140425224714.GF9218@google.com>

Thanks.

Reworded it that we remove it since all callers now use QUIET_ON_ERR

On Fri, Apr 25, 2014 at 3:47 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ronnie Sahlberg wrote:
>
>> Since we now pass meaningful error messages back from ref_transaction_commit
>> on failures, we no longer need to provide a onerr argument.
>
> Yay!  More precisely, now that all callers use
> UPDATE_REFS_QUIET_ON_ERR there's no need to support any other
> behavior.
>
> Thanks for cleaning up the error handling here.