From: Ronnie Sahlberg <sahlberg@google.com>
Date: Mon, 28 Apr 2014 18:23:24 GMT
Subject: Re: [PATCH v3 06/19] refs.c: make update_ref_write to return error string on failure
Message-ID: <CAL=YDW=uavcAD==aES8zwzTstDo17paiRBhRYmYB0HkfMo8wRg@mail.gmail.com>
In-Reply-To: <20140425224507.GE9218@google.com>

Done, thanks

On Fri, Apr 25, 2014 at 3:45 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ronnie Sahlberg wrote:
>
>> Change update_ref_write to also return an error string on failure.
>> This makes the error avaialbel to ref_transaction_commit callers if the
>> transaction failed dur to update_ref_sha1/write_ref_sha1 failures.
>
> Nits:
>
>  * available
>  * during
>
> Probably should come right after or before patch 3.  Same nit as patch
> 3 about using asprintf or passing in a pointer to strbuf.