From: Ronnie Sahlberg <sahlberg@google.com>
Date: Wed, 14 May 2014 15:24:48 GMT
Subject: Re: [PATCH v6 04/42] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors
Message-ID: <CAL=YDW=pN=L0v2RsiaanuAOR==_RENX0xnbwnWbJXKfih_oeVQ@mail.gmail.com>
In-Reply-To: <20140514000402.GZ9218@google.com>

Thanks.

I updated the commit message to highlight that this means the error
string can now be passed all the way back to the caller.

On Tue, May 13, 2014 at 5:04 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ronnie Sahlberg wrote:
>
>> Make ref_update_reject_duplicates return any error that occurs through a
>> new strbuf argument.
>
> Sensible.  The caller-visible effect would be that now
> ref_transaction_commit() can pass back a helpful error message through
> its "err" argument when asked to make multiple updates for the same
> ref.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>