From: Aniket Gupta Date: Sun, 11 Oct 2026 19:22:00 GMT Subject: Re: [PATCH] fast-import: fix lookup for new commits Message-ID: Hello Marc, I tried this on top of 6de20f609 with DEVELOPER=1 and did not get warnings. > Queries for commits created during the same 'git fast-import' session > result in a crash: > < reset refs/heads/newbranch > < from > > fatal: not a valid commit: I was able to repro this. With the patch fsck is clean and it works nicely. Same goes for "commit" with "from ", a tag made in the same session, and a tag of a tag. Existing commits and tags and "from " behave like before. One small nitpick: there is a double space in "'git fast-import' session". > to avoid crash and (eventually) improve lookup speed. Did you measure this? If not, maybe drop it or say it is only a possible side effect. > +static struct object_entry *dereference(struct object_entry *oe, struct object_id *oid); This is over 80 columns, can it be wrapped like the definition? > builtin/fast-import.c | 18 ++++++++++++++---- I could not find a test for this. Can you add one to t9300? You can get the new oid with get-mark and use it in a "reset ... from " in the same stream. Thanks, Aniket