From: Tanga Joris Date: Thu, 05 Nov 2026 14:47:00 GMT Subject: Re: [PATCH v1] hash: handle invalid algorithms when formatting object IDs Message-ID: In-Reply-To: <20261103043756.61627-1-eddinen77@gmail.com> Hello shrimech, Thank you for the patch. I tried it on top of master (0ffa3e35c7). "cargo test" passes, and the new test fails without your change to fmt(), so it does catch the problem. On Tue, 3 Nov 2026 at 07:42, shrimech wrote: > + Err(e) => write!(f, ":invalid-hash-algo-{}", e.0), I have one question. In the C code, algo 0 is not treated as an error when printing: hash_to_hex_algop_r() in hex.c falls back to the default hash ("Our struct object_id has been memset to 0, so default to printing using the default hash"). Your test uses algo 0 as the invalid case, so for algo 0 the Rust output would be different from C. Is that intended? brian m. carlson wrote most of src/hash.rs, so I have added him on Cc, I hope that is okay:) Also the first patch versions can be sent as [PATCH] instead of [PATCH v1]. Either way works. The v1 format is less common though. Thanks, Tanga