From: Pasha Bolokhov <pasha.bolokhov@gmail.com>
Date: Tue, 10 Jun 2014 03:18:12 GMT
Subject: Re: [PATCH v5] Add an explicit GIT_DIR to the list of excludes
Message-ID: <CAKpPgveXen9sQefo8dva1Uy4YOyroT6cPXLzgUvxj93Zqw13zw@mail.gmail.com>
In-Reply-To: <CACsJy8AyvkA20mD283=hWp7WFJXBu3-ViXHuS4jtMzz2hpBi2Q@mail.gmail.com>

> On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov <pasha.bolokhov@gmail.com> wrote:
>> +       /* only add it if GIT_DIR does not end with '.git' or '/.git' */
>> +       if (len < 4 || strcmp(n_git + len - 4, ".git") ||
>> +           (len > 4 && n_git[len - 5] != '/')) {
>
> Hmm.. should we exclude "foobar.git" as well?

    Why wouldn't we? Everything that has basename ".git" is hard-wired
to be excluded, but everything else, including "foobar.git" should be
added to the excludes manually... How is it better than just "foobar"?