From: Wink Saville <wink@saville.com>
Date: Tue, 27 Mar 2018 22:03:54 GMT
Subject: Re: [PATCH v5] json_writer: new routines to create data in JSON format
Message-ID: <CAKk8ispn6kYQUqPbMc74HfdZ6hj6BwtgytgD5guLLfauspDKuA@mail.gmail.com>
In-Reply-To: <20180327210233.29076-2-git@jeffhostetler.com>

On Tue, Mar 27, 2018 at 2:02 PM <git@jeffhostetler.com> wrote:
>
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Add a series of jw_ routines and "struct json_writer" structure to compose
> JSON data.  The resulting string data can then be output by commands wanting
> to support a JSON output format.

<snip>

>
>
>
>  void jw_object_intmax(struct json_writer *jw, const char *key, intmax_t value)
> +{
> +       object_common(jw, key);
> +       strbuf_addf(&jw->json, "%"PRIdMAX, (intmax_t)value);

Cast is not necessary.

> +}
> +

<snip>

>
> +void jw_array_intmax(struct json_writer *jw, intmax_t value)
> +{
> +       array_common(jw);
> +       strbuf_addf(&jw->json, "%"PRIdMAX, (intmax_t)value);

Cast is not necessary

>
> +}
> +

<snip>

-- Wink