From: Wink Saville <wink@saville.com>
Date: Mon, 26 Mar 2018 18:43:46 GMT
Subject: Re: [RFC PATCH v5 0/8] rebase-interactive
Message-ID: <CAKk8isp_qx1ajgRryhBw6TYBoaa8fJU6hP3JyUWAx20knQSLXA@mail.gmail.com>
In-Reply-To: <3d845e99-e392-a62f-b83e-33b58482fc54@jeffhostetler.com>

> I was just going by what the reported compiler error message was.
> It said that "unsigned long" didn't match the uint64_t variable.
> And that made me nervous.
>
> If all of the platforms we build on define uintmax_t >= 64 bits,
> then it doesn't matter.
>
> If we do have a platform where uintmax_t is u32, then we'll have a
> lot more breakage than in just the new function I added.
>
> Thanks,
> Jeff

Should we add a "_Static_assert" that sizeof(uintmax_t) >= sizeof(uint64_t) ?