From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
Date: Mon, 15 Jun 2020 19:45:12 GMT
Subject: Re: [PATCH v4 4/8] cmake: support for testing git with ctest
Message-ID: <CAKiG+9XbpLpWWsEg+RCqxzJ70Hx-=qqxDL_Yy96weM5fLoVwuA@mail.gmail.com>
In-Reply-To: <20200615140236.1707-1-oystwa@gmail.com>

On Mon, Jun 15, 2020 at 7:32 PM Øystein Walle <oystwa@gmail.com> wrote:
>
> > +
> > +if(BUILD_TESTING)
> > +
>
> This variable should perhaps be declared as an option using option()[1] since
> it's a knob the user is supposed to be able to switch. This makes it listed by
> `cmake -L`, and shown in ccmake and cmake-gui. In short, it's made more
> disoverable.
>

When you `include(CTest)` the option BUILD_TESTING is automatically added.

Thank You,
Sibi Siddharthan