From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
Date: Wed, 13 May 2020 20:07:13 GMT
Subject: Re: [PATCH v2 02/11] cmake: generate the shell/perl/python scripts and templates, translations
Message-ID: <CAKiG+9W+ba1ZFqKb=ADGQy146gNB7zQVOADGUqBZ4ULQM7XX9w@mail.gmail.com>
In-Reply-To: <xmqq7dxgc0mc.fsf@gitster.c.googlers.com>

On Wed, May 13, 2020 at 2:49 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Sibi Siddharthan via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Sibi Siddharthan <sibisiddharthan.github@gmail.com>
> >
> > This patch implements the placeholder substitution to generate, say,
> > `git-request-pull` from `git-request-pull.sh`.
> >
> > The shell/perl/python scripts and template are generated using CMake
> > (very similar to what sed does).
>
> We do not say "This patch does X" or "I do Y in this patch".
> perhaps.
>
>         Implement the placeholder substitution to generate scripted
>         Porcelain commands, e.g. git-request-pull out of
>         git-request-pull.sh
>
>         Generate scripts and templates using CMake, instead of using
>         sed like the build procedure in the Makefile does.
>

Will reword.

Thank You,
Sibi Siddharthan