From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
Date: Tue, 08 Feb 2022 01:47:12 GMT
Subject: Re: [PATCH v3 2/2] t/lib-read-tree-m-3way: indent with tabs
Message-ID: <CAJyCBOQR5wWkQhcVBVC7xJQDsaciifmX5LVuwPhBX2sVLMB7bw@mail.gmail.com>
In-Reply-To: <CAP8UFD0c=TeBwcyWo_GKLKV7Y8837beHLk7JGqfF9_DU79NWig@mail.gmail.com>

On Mon, Feb 7, 2022 at 7:54 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Sun, Feb 6, 2022 at 10:51 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> wrote:
> >
> > As Documentation/CodingGuidelines says, our shell scripts
> > (including tests) are to use HT for indentation, but this script
>
> Documentation/CodingGuidelines talks about "tabs" for indentation not
> "HT", so it would be more consistent to talk about "tabs" here too, or
> at least to say something like "are to use HT (horizontal tab) for
> indentation".

Agree, it should be phrased in a more consistent and understandable way.

> > uses 4-column indent with SP. Fix this.
>
> Same for "SP" here vs "space" in our doc. (Also note that `man ascii`
> talks about "HT" and "SPACE", not "SP".)

Agree.

--
Thanks,
Shaoxuan