From: Dominique Quatravaux <domq@google.com>
Date: Fri, 09 Mar 2012 09:52:03 GMT
Subject: Re: [PATCHv2 1/2] rebase -i: optimize the creation of the todo file
Message-ID: <CAJh6GrH3x-Fz5gqKdu_fcmH0OH3KG8En3H2vURKhkYuiC+s59g@mail.gmail.com>
In-Reply-To: <7vpqcm85rs.fsf@alter.siamese.dyndns.org>

On Fri, Mar 9, 2012 at 10:47 AM, Junio C Hamano <gitster@pobox.com> wrote:
> David Barr <davidbarr@google.com> writes:
>
>> I do notice however that the output being fed to sed expands like so:
>>
>>   commit >634a5f265ad729b91266de65272e2b5a35d05b1c
>>   >634a5f265ad729b91266de65272e2b5a35d05b1c 634a5f2 INSTALL: warn [...]
>>   commit >828ea97de486c1693d6e4f2c7347acb50235a85d
>>   >828ea97de486c1693d6e4f2c7347acb50235a85d 828ea97 Git 1.7.9
>>
>> Maybe the format spec and sed command could use a little tuning.
>
> Why would that be a problem, though?  The sed script picks only
> lines that begin with '>' and discards the traditional diff-tree
> style per commit header, no?

I assume that David wants to have

  commit >634a5f265ad729b91266de65272e2b5a35d05b1c
  634a5f2 INSTALL: warn [...]

and chew on that with sed.

-- 
  Dominique Quatravaux
  +41 79 609 40 72