From: Patryk Obara <patryk.obara@gmail.com>
Date: Mon, 22 Jan 2018 12:44:00 GMT
Subject: Re: [PATCH v2 05/14] sha1_file: convert hash_sha1_file to object_id
Message-ID: <CAJfL8+QcfaypDagYDjCw=eFqUhhFZ5qyMgjQcoyshnvnh7aTmQ@mail.gmail.com>
In-Reply-To: <20180122114925.GA5980@ash>

On 22 January 2018 at 12:49, Duy Nguyen <pclouds@gmail.com> wrote:
> On Mon, Jan 22, 2018 at 12:04:28PM +0100, Patryk Obara wrote:
>> @@ -969,7 +969,7 @@ static int ident_to_worktree(const char *path, const char *src, size_t len,
>>
>>               /* step 4: substitute */
>>               strbuf_addstr(buf, "Id: ");
>> -             strbuf_add(buf, sha1_to_hex(sha1), 40);
>> +             strbuf_add(buf, sha1_to_hex(oid.hash), GIT_SHA1_HEXSZ);
>
> oid_to_hex()?

I didn't do it originally because the size of hash is explicitly
passed as the third parameter.
I should probably replace this line with:

strbuf_addstr(buf, oid_to_hex(&oid));

... since a hex representation is correctly 0-delimited anyway.
Will include in v3 unless there'll be some other suggestion :)

-- 
| ← Ceci n'est pas une pipe
Patryk Obara