From: Samuel Bronson <naesten@gmail.com>
Date: Wed, 18 Dec 2013 04:28:25 GMT
Subject: Re: [PATCH v4 2/3] diff: Let "git diff -O" read orderfile from any file, fail properly
Message-ID: <CAJYzjmdscmEVuT29wMVoeUoUag=0H-XDq2tkLPRtHEr51kOk5Q@mail.gmail.com>
In-Reply-To: <xmqq4n67m8og.fsf@gitster.dls.corp.google.com>

On Tue, Dec 17, 2013 at 5:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
> My point was that I did not see much value in reading the orderfile
> data from anything but a file.  At that point, you are not testing
> the "diff -O" orderfile option, but if strbuf_readline() reads from
> a non-regular file.

Oh, good point, now that you state it explicitly.  I'll remove it.