From: David Aguilar <davvid@gmail.com>
Date: Fri, 09 Mar 2012 06:20:51 GMT
Subject: Re: [PATCH v2] Maintaince script for l10n files and commits
Message-ID: <CAJDDKr7A1LN_r5v0yiacpEHTtEqQG2Hf=YZ6GbtsOHLadozDKA@mail.gmail.com>
In-Reply-To: <1331273307-64598-1-git-send-email-worldhello.net@gmail.com>

On Thu, Mar 8, 2012 at 10:08 PM, Jiang Xin <worldhello.net@gmail.com> wrote:
> diff --git a/po/po-helper.sh b/po/po-helper.sh
> new file mode 100755
> index 0000000..166ebb7
> --- /dev/null
> +++ b/po/po-helper.sh
> @@ -0,0 +1,387 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2012 Jiang Xin
> +
> +GIT=git

I think it's customary to just write `git` in shell scripts.  It looks
nicer then seeing $GIT everywhere, IMO.  I guess this could be helpful
in the future but I don't see GIT being reassigned anywhere.

Cheers,
-- 
David