From: David Aguilar <davvid@gmail.com>
Date: Tue, 21 May 2013 22:39:15 GMT
Subject: Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto
Message-ID: <CAJDDKr61R0aPFWT=vNz3nSvR-1azTG3Zox=wAO7rB_iCvxhdZg@mail.gmail.com>
In-Reply-To: <519BC8B0.5050100@web.de>

On Tue, May 21, 2013 at 12:19 PM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 2013-05-21 00.52, Junio C Hamano wrote:
>> Thanks, will replace da/darwin with this round.
> (May be late response, not sure if this is the right email thread.
> I eventually managed to compile under 10.6, what we have on pu)
>
> One minor nit, or 2:
> imap-send.c: In function ‘cram’:
> imap-send.c:913: warning: statement with no effect
>
> This fixes it:
>
> diff --git a/imap-send.c b/imap-send.c
> index 8ea180f..11577c9 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -35,7 +35,7 @@ typedef void *SSL;
> #define HMAC_Init(hmac, key, len, algo) CCHmacInit(hmac, algo, key, len)
> #define HMAC_Update CCHmacUpdate
> #define HMAC_Final(hmac, hash, ptr) CCHmacFinal(hmac, hash)
> -#define HMAC_CTX_cleanup
> +#define HMAC_CTX_cleanup(c)
> #define EVP_md5() kCCHmacAlgMD5
> #else
> #include <openssl/evp.h>

Thanks.  This change compiles fine on Mountain Lion (10.8) as well.
--
David