From: Allen Hubbe <allenbh@gmail.com>
Date: Fri, 22 May 2015 12:15:02 GMT
Subject: Re: [PATCH v2] send-email: Add simple email aliases format
Message-ID: <CAJ80sav9QEBnqbib5mG9O+XkWvgcH+C4aK+p4AdnE53_goNtCw@mail.gmail.com>
In-Reply-To: <CAPig+cSDAagVNhdobtTDGrdzLNSxKpOtUhEEDq+NLQZBOoWJxg@mail.gmail.com>

On Thu, May 21, 2015 at 11:59 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Thu, May 21, 2015 at 11:19 PM, Allen Hubbe <allenbh@gmail.com> wrote:
>> On May 21, 2015 9:05 PM, "Eric Sunshine" <sunshine@sunshineco.com> wrote:
>>> On Thu, May 21, 2015 at 8:16 PM, Allen Hubbe <allenbh@gmail.com> wrote:
>>> > +test_expect_success $PREREQ 'sendemail.aliasfiletype=simple' '
>>> > +       clean_fake_sendmail && rm -fr outdir &&
>>> > +       git format-patch -1 -o outdir &&
>>> > +       {
>>> > +               echo "alice: Alice W Land <awol@example.com>"
>>> > +               echo "bob: Robert Bobbyton <bob@example.com>"
>>> > +               echo "chloe: chloe@example.com"
>>> > +               echo "abgroup: alice, bob"
>>> > +               echo "bcgrp: bob, chloe, Other <o@example.com>"
>>> > +       } >~/.tmp-email-aliases &&
>>>
>>> A here-doc would be easier to maintain and read:
>> A here-doc does not flow nicely in an indented block.  Each line in
> That's true if you use <<EOF here-doc, but not for <<-EOF, as I did in
> the example. With <<-EOF, all leading tabs are stripped from the input
> lines, including from the EOF line, which is why it can be indented to
> the same level as the other code in the test. The added '\' in <<-\EOF
> from my example indicates that you don't want/expect any interpolation
> inside the here-doc. The <<-\EOF form is used extensively throughout
> the Git test suite.

Alright.