From: Allen Hubbe Date: Mon, 01 Jun 2015 11:43:08 GMT Subject: Re: [PATCH 1/9] send-email: further document missing sendmail aliases functionality Message-ID: In-Reply-To: <1433111371-19573-2-git-send-email-sunshine@sunshineco.com> According to the documentation, the parser should print a warning for any explicitly unsupported constructs. These are now explicitly unsupported, so the parser should warn on |, /, and :include: . Perhaps the lines that match should be ignored like the others, too. On Sun, May 31, 2015 at 6:29 PM, Eric Sunshine wrote: > Sendmail aliases[1] supports expansion to a file ("/path/name") or > pipe ("|command"), as well as file inclusion (":include: /path/name"), > however, our implementation does not support such functionality. > > [1]: https://www.freebsd.org/cgi/man.cgi?query=aliases&sektion=5 > > Signed-off-by: Eric Sunshine > --- > Documentation/git-send-email.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt > index b48a764..e6d466e 100644 > --- a/Documentation/git-send-email.txt > +++ b/Documentation/git-send-email.txt > @@ -396,6 +396,9 @@ sendmail;; > contain a `"` symbol are ignored. > * Line continuations are not supported: lines that start with > whitespace characters, or end with a `\` symbol are ignored. > +* Redirection to a file (`/path/name`) or pipe (`|command`) is not > + supported. > +* File inclusion (`:include: /path/name`) is not supported. > * Warnings are printed on the standard error output for any > explicitly unsupported constructs, and any other lines that are not > recognized by the parser. > -- > 2.4.2.538.g5f4350e >