From: Tamir Duberstein Date: Mon, 08 Jun 2026 22:39:48 GMT Subject: Re: [PATCH] ref-filter: restore prefix-scoped iteration Message-ID: In-Reply-To: On Mon, Jun 8, 2026 at 2:36 PM Junio C Hamano wrote: > > Tamir Duberstein writes: > > > diff --git a/ref-filter.c b/ref-filter.c > > index 1da4c0e60d..2388a57b39 100644 > > --- a/ref-filter.c > > +++ b/ref-filter.c > > @@ -3315,19 +3315,31 @@ static int do_filter_refs(struct ref_filter *filter, unsigned int type, refs_for > > prefix = "refs/tags/"; > > > > if (prefix) { > > Below, adding an extra call to get_main_ref_store(the_repository) > makes one line unnecessarily split and harder to read. How about > doing > > struct ref_store *store = get_main_ref_store(the_repository); > > upfront here, and then use that to replace these two calls of > get_main_ref_store(the_repository)? Yep, done in v2. Thanks for the review! By the way, how long should I wait before sending new versions of my patches? I have 4 outstanding at the moment.