From: Harald Nordgren Date: Wed, 17 Jun 2026 11:17:08 GMT Subject: Re: [PATCH v15 0/7] branch: delete-merged Message-ID: In-Reply-To: On Wed, Jun 17, 2026 at 12:01 PM Phillip Wood wrote: > > Hi Harald > > Our SubmittingPatches documentation recommends waiting for the > discussion to settle before sending a new version. When you know someone > is going send more comments on a series it is a good idea to wait for > them before sending a new version to avoid too much churn on the list > which makes it hard for people to keep up. I'm not going to read this > version in detail because I know another version will be needed but I > did spot a couple of things in the summary below. Got it. I think I am waiting a fair bit between sending new versions. My last version here was 2 days ago. > Not changing force sounds like a bad idea. The whole point of unpacking > the flags at the start of the function is to avoid accidental > regressions. Unpacking the flags into separate variables means the rest > of the function does not need to know that the function arguments have > changed. My reason for keeping it like this was to avoid the slightly awkward double re-assignment of both flag and boolean: ``` case FILTER_REFS_REMOTES: ... flags |= DELETE_BRANCH_FORCE; force = true; ``` But your way is likely still better, because the definitions at the top of the function are clearer. Harald