From: Harald Nordgren Date: Mon, 28 Sep 2026 16:13:00 GMT Subject: Re: [PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them Message-ID: In-Reply-To: > I wonder whether it makes sense to have these warnings in the first > place. > > Part of the reason why we have these checks is that we allow the > installation of these tools to fail, and if so we know to gracefully > continue anyway. Tests will be skipped, and the pipeline will be green > in such a case. But is that even a safe thing to do? I strongly doubt > that we'd start to notice such failures anytime soon, so it very much > gives us a false sense of confidence. > > So I'd suggest that instead of warning, we should make the whole build > fail outright if we fail to install any of those tools. And once we do, > these warnings here become quite useless, because we know that the build > would fail on platforms where we expect the tools to be present. And on > platforms where we don't, the warning is pointless anyway. Fine by me! Harald