From: Harald Nordgren Date: Sun, 04 Oct 2026 11:51:56 GMT Subject: Re: [PATCH v5 0/2] ci: link failure and leak annotations to the test script Message-ID: In-Reply-To: <8b873f2e-b395-4044-ab15-f1eab4148447@gmail.com> On Sat, Oct 3, 2026 at 9:02 PM Phillip Wood wrote: > > On 03/10/2026 14:03, Phillip Wood wrote: > > After spending some time clicking around in Github I > > think what that patch changes is not the test output of individual jobs > > which you linked to above, but what is displayed on the summary page at > > > > https://github.com/git/git/actions/runs/36979818141?pr=2426 > > > > That page shows a list of annotations with links to the changes in the > > failed test file. That is a useful improvement > > But it seems it is only useful if the test changed is in that example. > If I look at the summary for the CI run from v3 of this series [1] then > I can see a test failure in t1022 > > linux-leaks(ubuntu-rolling): t/t1022-read-tree-partial-clone.sh#L8 > failed: t1022.1 read-tree in partial clone prefetches in one batch > > If I click on the link [2] it does not take me to that test file though, > because it was not changed. Yes, unfortunately GitHub won't let us link to a line that was not changed in that PR. > That makes this somewhat less useful than I > initially thought. The current behavior is that when you click on those > links in the summary page it takes you to the test output for the job > that failed which seems more useful. For example [3] is recent test run > that had a leak and clicking on > > linux-leaks:(ubuntu-rolling): > failed: t1092.58 submodule handling > > Takes me to [4] which where I can click to expand the output of the > failing test. > ... > [1] https://github.com/git/git/actions/runs/36537917146?pr=2426 > [2] https://github.com/git/git/pull/2426/files#annotation_82189987516 > [3] https://github.com/benknoble/git/actions/runs/36033463504 > [4] > https://github.com/benknoble/git/actions/runs/36033463504/job/107747745741#step:9:5333 Is this enough to call this a regression? Then maybe it's not worth doing this part at all. Harald