From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Mon, 26 Oct 2026 09:59:58 GMT
Subject: Re: [PATCH v3 1/4] imap-send: wait for the tunnel command to finish
Message-ID: <CAHwyqnXAncLAM1q8m_OZmv=c_gajrgR4mK4gCWJ_zEGHcj+N3A@mail.gmail.com>
In-Reply-To: <at8gbEmbW8b5cDjo@pks.im>

> > +     if (ictx->cfg->tunnel)
> > +             finish_command(&imap->tunnel);
>
> Hmm, okay. Do we _know_ that `ictx->cfg->tunnel` is always properly
> initialized in case we call `imap_close_server()`? Or are there error
> paths where it might not be initialized yet? If the latter I think we
> might see weird behaviour here as the function does not seem to be safe
> when called on an uninitialized command.
>
> Maybe we should make `imap->tunnel` an allocated pointer instead so that
> we know to only finish it when allocated and initialized?

Good idea.

> > @@ -1163,19 +1166,20 @@ static struct imap_store *imap_open_store(struct imap_server_conf *srvc, const c
> >       /* open connection to IMAP server */
> >
> >       if (srvc->tunnel) {
> > -             struct child_process tunnel = CHILD_PROCESS_INIT;
> > +             struct child_process *tunnel = &imap->tunnel;
>
> Nit: I would have avoided this local variable, it doesn't help us anyway
> to shrink the diff.

Ok.


Harald