From: Harald Nordgren Date: Mon, 19 Oct 2026 14:50:51 GMT Subject: Re: [PATCH/RFC] upload-pack: fix slow fetches from a shallow repository Message-ID: In-Reply-To: > The advertise_shallow_grafts() function is written for protocol > v0 and uses packet_write_fmt() to write raw data directly to the > named file descriptor (in this case, fd #1). > > However, protocol v2 negotiation uses the packet_writer API. When > sideband-all is in use, the response must be multiplexed over the > sideband channel. Because the updated code fails to use the > packet_writer API, 'shallow' lines are written without the '\001' > band designator. The other side then interprets 's' (the first > byte of 'shallow', which is 115 in decimal) as the sideband channel > and dies with a protocol violation. Thanks for pointing this out! I'll take a look! Harald